From cf69ed05d2d42ad8b18fa791e1b256d8d452bfdf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:52 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8     | 2 ++
 __init__.py | 4 ++--
 res.py      | 2 --
 setup.py    | 8 +++++---
 4 files changed, 9 insertions(+), 7 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/__init__.py b/__init__.py
index 2da691ff87..90d1804c17 100644
--- a/__init__.py
+++ b/__init__.py
@@ -2,10 +2,10 @@
 # this repository contains the full copyright notices and license terms.
 
 from trytond.pool import Pool
-from .res import *
+from . import res
 
 
 def register():
     Pool.register(
-        User,
+        res.User,
         module='ldap_authentication', type_='model')
diff --git a/res.py b/res.py
index 23ae2ec621..a8d05ff7a2 100644
--- a/res.py
+++ b/res.py
@@ -13,8 +13,6 @@ from trytond.pool import PoolMeta
 from trytond.config import config, parse_uri
 from trytond.exceptions import LoginException
 
-__all__ = ['User']
-
 logger = logging.getLogger(__name__)
 section = 'ldap_authentication'
 
diff --git a/setup.py b/setup.py
index 06b55429f3..aabef7102a 100755
--- a/setup.py
+++ b/setup.py
@@ -79,8 +79,9 @@ setup(name=name,
     keywords='tryton ldap authentication',
     package_dir={'trytond.modules.ldap_authentication': '.'},
     packages=(
-        ['trytond.modules.ldap_authentication'] +
-        ['trytond.modules.ldap_authentication.%s' % p for p in find_packages()]
+        ['trytond.modules.ldap_authentication']
+        + ['trytond.modules.ldap_authentication.%s' % p
+            for p in find_packages()]
         ),
     package_data={
         'trytond.modules.ldap_authentication': (info.get('xml', [])
@@ -93,7 +94,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',