From d62e0bf59a2b3977ec9a7b104b4092c8b4fa5a87 Mon Sep 17 00:00:00 2001 From: Sergi Almacellas Abellana Date: Tue, 30 May 2017 12:37:46 +0200 Subject: [PATCH] Ensure None and '' match when comparing requests description issue6529 review38391002 --- purchase_request.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/purchase_request.py b/purchase_request.py index ef2aa42d2d..0e7c9637ec 100644 --- a/purchase_request.py +++ b/purchase_request.py @@ -376,11 +376,15 @@ class CreatePurchase(Wizard): if (getattr(self.ask_party, 'party', None) and getattr(self.ask_party, 'company', None)): + def compare_string(first, second): + return (first or '') == (second or '') + def to_write(request): return (not request.purchase_line and not request.party and request.product == self.ask_party.product - and request.description == self.ask_party.description) + and compare_string( + request.description, self.ask_party.description)) reqs = filter(to_write, requests) if reqs: Request.write(reqs, {