From de51de4deab45a37b44af1a1b6ca77ae2cc647d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:52 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 asset.py          | 2 --
 invoice.py        | 2 --
 setup.py          | 7 ++++---
 tests/__init__.py | 2 +-
 5 files changed, 7 insertions(+), 8 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/asset.py b/asset.py
index f6a59c81a5..66da154249 100644
--- a/asset.py
+++ b/asset.py
@@ -6,8 +6,6 @@ from trytond.transaction import Transaction
 
 from trytond.modules.analytic_account import AnalyticMixin
 
-__all__ = ['Asset']
-
 
 class Asset(AnalyticMixin, metaclass=PoolMeta):
     __name__ = 'account.asset'
diff --git a/invoice.py b/invoice.py
index fc9ee0a5de..106de101bc 100644
--- a/invoice.py
+++ b/invoice.py
@@ -6,8 +6,6 @@ from trytond.pyson import Eval, If
 
 from trytond.modules.analytic_account import AnalyticMixin
 
-__all__ = ['InvoiceLine', 'AnalyticAccountEntry']
-
 
 class InvoiceLine(AnalyticMixin, metaclass=PoolMeta):
     __name__ = 'account.invoice.line'
diff --git a/setup.py b/setup.py
index f38f8a2b0c..79760ac73c 100755
--- a/setup.py
+++ b/setup.py
@@ -81,8 +81,8 @@ setup(name=name,
     keywords='tryton analytic account invoice',
     package_dir={'trytond.modules.analytic_invoice': '.'},
     packages=(
-        ['trytond.modules.analytic_invoice'] +
-        ['trytond.modules.analytic_invoice.%s' % p for p in find_packages()]
+        ['trytond.modules.analytic_invoice']
+        + ['trytond.modules.analytic_invoice.%s' % p for p in find_packages()]
         ),
     package_data={
         'trytond.modules.analytic_invoice': (info.get('xml', [])
@@ -95,7 +95,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index a9b5850791..5d3d279500 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.analytic_invoice.tests.test_analytic_invoice import suite
+    from trytond.modules.analytic_invoice.tests.test_analytic_invoice import suite  # noqa: E501
 except ImportError:
     from .test_analytic_invoice import suite