From dfb345dc86147f0537d3f11d9fd589ecaf182cbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Tue, 4 Aug 2026 14:43:53 +0200 Subject: [PATCH] Use boolean operator to test remaining quantity of blanket agreement when closing The remaining quantity may be None if the line has no quantity set. But the getter ensure that the remaining quantity is always greater or equal to 0. Closes #14987 (grafted from 640dfcc6d6d36f3fbbf8d232c760ea1c560c996d) --HG-- branch : 8.0 --- modules/purchase_blanket_agreement/purchase.py | 2 +- modules/sale_blanket_agreement/sale.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/purchase_blanket_agreement/purchase.py b/modules/purchase_blanket_agreement/purchase.py index 91abc9ff37..e101c50f90 100644 --- a/modules/purchase_blanket_agreement/purchase.py +++ b/modules/purchase_blanket_agreement/purchase.py @@ -425,7 +425,7 @@ class BlanketAgreement(Workflow, ModelSQL, ModelView, ChatMixin): cls.set_date(agreements, 'to_date') for agreement in agreements: if agreement.to_date > today: - if any(l.remaining_quantity > 0 for l in agreement.lines): + if any(l.remaining_quantity for l in agreement.lines): warning_key = Warning.format( 'closed_remaining_quantity', [agreement]) if Warning.check(warning_key): diff --git a/modules/sale_blanket_agreement/sale.py b/modules/sale_blanket_agreement/sale.py index 235caa12af..4c2ac2da8c 100644 --- a/modules/sale_blanket_agreement/sale.py +++ b/modules/sale_blanket_agreement/sale.py @@ -426,7 +426,7 @@ class BlanketAgreement(Workflow, ModelSQL, ModelView, ChatMixin): cls.set_date(agreements, 'to_date') for agreement in agreements: if agreement.to_date > today: - if any(l.remaining_quantity > 0 for l in agreement.lines): + if any(l.remaining_quantity for l in agreement.lines): warning_key = Warning.format( 'closed_remaining_quantity', [agreement]) if Warning.check(warning_key):