From e506de796427cc18f9bfec7e8293d492460562d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:53 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           |  2 ++
 __init__.py       | 20 ++++++++++----------
 production.py     |  2 --
 routing.py        |  2 --
 setup.py          |  7 ++++---
 tests/__init__.py |  2 +-
 work.py           |  2 --
 7 files changed, 17 insertions(+), 20 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/__init__.py b/__init__.py
index 0403cf4088..8accc56477 100644
--- a/__init__.py
+++ b/__init__.py
@@ -2,18 +2,18 @@
 # this repository contains the full copyright notices and license terms.
 
 from trytond.pool import Pool
-from .work import *
-from .routing import *
-from .production import *
+from . import work
+from . import routing
+from . import production
 
 
 def register():
     Pool.register(
-        WorkCenterCategory,
-        WorkCenter,
-        Work,
-        WorkCycle,
-        Operation,
-        RoutingStep,
-        Production,
+        work.WorkCenterCategory,
+        work.WorkCenter,
+        work.Work,
+        work.WorkCycle,
+        routing.Operation,
+        routing.RoutingStep,
+        production.Production,
         module='production_work', type_='model')
diff --git a/production.py b/production.py
index 765780f6af..5b231df6d1 100644
--- a/production.py
+++ b/production.py
@@ -11,8 +11,6 @@ from trytond.model.exceptions import AccessError
 from trytond.pyson import Eval, Bool
 from trytond.transaction import Transaction
 
-__all__ = ['Production']
-
 
 class Production(metaclass=PoolMeta):
     __name__ = 'production'
diff --git a/routing.py b/routing.py
index 8e625c35e4..e66754e967 100644
--- a/routing.py
+++ b/routing.py
@@ -3,8 +3,6 @@
 from trytond.pool import PoolMeta, Pool
 from trytond.model import fields
 
-__all__ = ['Operation', 'RoutingStep']
-
 
 class Operation(metaclass=PoolMeta):
     __name__ = 'production.routing.operation'
diff --git a/setup.py b/setup.py
index 180289ff70..507ad157d7 100755
--- a/setup.py
+++ b/setup.py
@@ -79,8 +79,8 @@ setup(name=name,
     keywords='tryton production work',
     package_dir={'trytond.modules.production_work': '.'},
     packages=(
-        ['trytond.modules.production_work'] +
-        ['trytond.modules.production_work.%s' % p for p in find_packages()]
+        ['trytond.modules.production_work']
+        + ['trytond.modules.production_work.%s' % p for p in find_packages()]
         ),
     package_data={
         'trytond.modules.production_work': (info.get('xml', [])
@@ -94,7 +94,8 @@ setup(name=name,
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
         'Intended Audience :: Manufacturing',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index db39c8f43e..b957db350b 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.production_work.tests.test_production_work import suite
+    from trytond.modules.production_work.tests.test_production_work import suite  # noqa: E501
 except ImportError:
     from .test_production_work import suite
 
diff --git a/work.py b/work.py
index 1fe213185a..9e7c20266c 100644
--- a/work.py
+++ b/work.py
@@ -17,8 +17,6 @@ from trytond.transaction import Transaction
 from trytond.modules.product import price_digits
 from .exceptions import PickerError
 
-__all__ = ['WorkCenterCategory', 'WorkCenter', 'Work', 'WorkCycle']
-
 
 class WorkCenterCategory(ModelSQL, ModelView):
     'Work Center Category'