From ebe5835f4407fea4ba6170f8e054b43e6410e137 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Tue, 15 Jan 2019 00:03:52 +0100 Subject: [PATCH] Test if origin is ModelStorage instance before calling rec_name The origin could have a negative id and so the value is a string which is not usable origin for record name. issue7948 review52581002 --- work.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/work.py b/work.py index c87935d485..39846c7fc9 100644 --- a/work.py +++ b/work.py @@ -7,7 +7,8 @@ from sql import Literal from sql.aggregate import Sum from trytond.i18n import gettext -from trytond.model import ModelView, ModelSQL, DeactivableMixin, fields, Unique +from trytond.model import ( + ModelView, ModelSQL, ModelStorage, DeactivableMixin, fields, Unique) from trytond.pyson import Not, Bool, Eval, If from trytond.transaction import Transaction from trytond.pool import Pool @@ -172,7 +173,7 @@ class Work(DeactivableMixin, ModelSQL, ModelView): return self.id def get_rec_name(self, name): - if self.origin: + if isinstance(self.origin, ModelStorage): return self.origin.rec_name else: return self.name