From f0aad0e20bbfc817023e4f886c11857d41caa9c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Tue, 21 Jan 2020 00:33:11 +0100
Subject: [PATCH] Check stock quantity before super calls

This avoid to call side effect method like set_number if the check fails.

issue8932
review276591002
---
 sale.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sale.py b/sale.py
index 55dfda049f..17002ebc20 100644
--- a/sale.py
+++ b/sale.py
@@ -22,15 +22,17 @@ class Sale(metaclass=PoolMeta):
     @ModelView.button
     @Workflow.transition('quotation')
     def quote(cls, sales):
-        super(Sale, cls).quote(sales)
+        # Check before setting the number
         cls._check_stock_quantity(sales)
+        super(Sale, cls).quote(sales)
 
     @classmethod
     @ModelView.button
     @Workflow.transition('confirmed')
     def confirm(cls, sales):
-        super(Sale, cls).confirm(sales)
+        # Check before queueing the process task
         cls._check_stock_quantity(sales)
+        super(Sale, cls).confirm(sales)
 
     @classmethod
     def _check_stock_quantity(cls, sales):