From f63344d2c1526df08ff8d75c33e2158e75c2d5af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:53 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 sale.py           | 9 ++-------
 setup.py          | 7 ++++---
 stock.py          | 2 --
 tests/__init__.py | 2 +-
 5 files changed, 9 insertions(+), 13 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/sale.py b/sale.py
index fec4ad8137..cc07a00acf 100644
--- a/sale.py
+++ b/sale.py
@@ -11,16 +11,11 @@ from trytond.model import (
 from trytond.pyson import Eval, Bool
 from trytond.tools import decistmt
 from trytond.transaction import Transaction
-from trytond.modules.company.model import CompanyMultiValueMixin, CompanyValueMixin
+from trytond.modules.company.model import (
+    CompanyMultiValueMixin, CompanyValueMixin)
 
 from .exceptions import FormulaError
 
-__all__ = [
-    'AdvancePaymentTerm', 'AdvancePaymentTermLine',
-    'AdvancePaymentTermLineAccount',
-    'AdvancePaymentCondition', 'Sale', 'SaleLine',
-    'HandleInvoiceException']
-
 
 class AdvancePaymentTerm(
         DeactivableMixin, ModelSQL, ModelView):
diff --git a/setup.py b/setup.py
index adc999f1d3..8fb9150091 100755
--- a/setup.py
+++ b/setup.py
@@ -81,8 +81,8 @@ setup(name=name,
     keywords='tryton sale advance payment',
     package_dir={'trytond.modules.sale_advance_payment': '.'},
     packages=(
-        ['trytond.modules.sale_advance_payment'] +
-        ['trytond.modules.sale_advance_payment.%s' % p
+        ['trytond.modules.sale_advance_payment']
+        + ['trytond.modules.sale_advance_payment.%s' % p
             for p in find_packages()]
         ),
     package_data={
@@ -97,7 +97,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/stock.py b/stock.py
index b35483e927..b2d9d71465 100644
--- a/stock.py
+++ b/stock.py
@@ -7,8 +7,6 @@ from trytond.pool import Pool, PoolMeta
 
 from .exceptions import ShippingBlocked
 
-__all__ = ['ShipmentOut']
-
 
 class ShipmentOut(metaclass=PoolMeta):
     __name__ = 'stock.shipment.out'
diff --git a/tests/__init__.py b/tests/__init__.py
index 29bcbec317..8a44009b34 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.sale_advance_payment.tests.test_sale_advance_payment import suite
+    from trytond.modules.sale_advance_payment.tests.test_sale_advance_payment import suite  # noqa: E501
 except ImportError:
     from .test_sale_advance_payment import suite