From fa4c2ae1fb87f8bfae4694cc81ff986fdbcfe317 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Tue, 10 Jun 2025 23:00:30 +0200
Subject: [PATCH] Limit the height of completion dropdown

The actions are set as sticky to be always visible.

Closes #14063
---
 sao/src/common.js | 21 +++++++++++----------
 sao/src/sao.less  | 17 +++++++++++++++++
 2 files changed, 28 insertions(+), 10 deletions(-)

diff --git a/sao/src/common.js b/sao/src/common.js
index e0e2b8b58f..e7cd7cb9ad 100644
--- a/sao/src/common.js
+++ b/sao/src/common.js
@@ -3745,14 +3745,15 @@
                 'data-toggle': 'dropdown'
             }).appendTo(this.dropdown);
             this.menu = jQuery('<ul/>', {
-                'class': 'dropdown-menu',
+                'class': 'dropdown-menu dropdown-completion',
                 'role': 'listbox'
             }).appendTo(this.dropdown);
-            this.separator = jQuery('<li/>', {
-                'role': 'separator',
-                'class': 'divider'
-            }).appendTo(this.menu);
-            this.separator.hide();
+            this.actions = jQuery('<li/>', {
+                'class': 'dropdown-header dropdown-action'
+            }).append(jQuery('<ul/>', {
+                'class': 'list-unstyled',
+            })).appendTo(this.menu);
+            this.actions.hide();
 
             this.source = source;
             this.match_selected = match_selected;
@@ -3806,12 +3807,12 @@
             if (create) {
                 actions.push(['create', Sao.i18n.gettext('Create...')]);
             }
-            this.menu.find('li.action').remove();
+            this.actions.find('li.action').remove();
             if (jQuery.isEmptyObject(actions)) {
-                this.separator.hide();
+                this.actions.hide();
                 return;
             }
-            this.separator.show();
+            this.actions.show();
             actions.forEach(function(action) {
                 var action_id = action[0];
                 var content = action[1];
@@ -3827,7 +3828,7 @@
                     }
                     this.input.val('');
                 })
-                .appendTo(this.menu);
+                .appendTo(this.actions.children().first());
             }, this);
         },
         _format: function(content) {
diff --git a/sao/src/sao.less b/sao/src/sao.less
index 8505e76c87..d02484efd8 100644
--- a/sao/src/sao.less
+++ b/sao/src/sao.less
@@ -141,6 +141,23 @@ html[theme="default"] {
     .user-select(text);
 }
 
+.dropdown-completion {
+    max-height: 50vh;
+    overflow-y: auto;
+
+    .dropdown-action {
+        background-color: @body-bg;
+        border-top: @dropdown-divider-bg solid 1px;
+        bottom: -5px;
+        position: sticky;
+
+        .action a {
+            clear: both;
+            display: block;
+        }
+    }
+}
+
 #tablist {
     display: flex;
     overflow-x: auto;