From fd47e01f1de72431022975d35f8c9efb4027aecc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Mon, 23 Mar 2015 21:19:09 +0100 Subject: [PATCH] Don't check period if value did not change issue4399 review13101002 --- period.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/period.py b/period.py index 7dde7d6c0f..5df0dbd848 100644 --- a/period.py +++ b/period.py @@ -250,9 +250,14 @@ class Period(ModelSQL, ModelView): actions = iter(args) args = [] for periods, values in zip(actions, actions): - for key in values.keys(): + for key, value in values.iteritems(): if key in ('start_date', 'end_date', 'fiscalyear'): - cls._check(periods) + def modified(period): + if key in ['start_date', 'end_date']: + return getattr(period, key) != value + else: + return period.fiscalyear .id != value + cls._check(filter(modified, periods)) break if values.get('state') == 'open': for period in periods: