Commit Graph
644 Commits
Author SHA1 Message Date
Cédric Krier ddb5fc3026 Manage selection function for Function field
ModelView automatically adds missing RPC definition for selection function but
only for Selection or Reference field. It should also do the same for Function
field which mimic such fields.

issue5903
review30531002
2016-09-27 12:19:47 +02:00
Cédric Krier 6261fa486f Improve ModelStorage.search_count by using no order and COUNT(*)
issue5877
review27651003
2016-09-27 12:18:16 +02:00
Cédric Krier 972a1b6c91 Do not link the cache of the instances if id is negative
Otherwise trytond will try to read it from the database and fail.

issue5874
2016-09-22 11:33:51 +02:00
Sergi Almacellas Abellana 35c3495bb9 Don't check access when executing trigger actions
issue5887
review27641002
2016-09-21 15:30:02 +02:00
Cédric Krier bf7148d9d3 Link the cache of the instances in xxx2Many setter
Just as it is done when browsing xxx2Many field, the instances set by the
xxx2Many fields should share the same local cache.

issue5874
review30471002
2016-09-21 00:36:49 +02:00
Sergi Almacellas Abellana 828afc310d Add sequence_ordered
issue5105
review25561002
2016-09-13 14:01:17 +02:00
Cédric Krier d305c26e54 Add support for derivative translations
This is done by calling first the getter method for the parent language for the
terms that are not yet cached. After existing translations are set for the
language. And finally the result is stored in the cache.
The synchronisation wizard remove also the translations that are identical to
their parent language.
The method load_module_graph adds all parent languages to be loaded for
derivation.

issue5443
review25581002
2016-09-10 23:25:03 +02:00
Cédric Krier 02fa7b240a Allow to call ModelSQL.__insert_history
Rename __insert_history into _insert_history to be able to call it
when records are manipulated via SQL queries.

issue5819
review32471002
2016-09-06 09:08:50 +02:00
Cédric Krier ae51da69a1 Consume only requested fields from Fields.get method
Badly written getter could return more values than requested. This can corrupt
the browse cache as it only filter on requested fields.

issue5805
review21221002
2016-08-25 19:14:13 +02:00
Cédric Krier 5a9ea33f85 Add Many2Many targets to all records
If at least one record had already the target, the target was not added to any
records. This is because the test for existing link was only done on the target
id instead of the tuple origin and target.

issue5792
review26551002
2016-08-19 21:34:47 +02:00
Cédric Krier 8b99a62f10 Use 'default_rec_name' context key in Model.default_get
This allow the client to set searched value as default rec_name when the user
choose to create the record.

issue4136
review22131002
2016-08-04 23:54:50 +02:00
Cédric Krier c4c6e6ed54 Do not set NOT NULL on any Binary fields
Even if the data is stored in the database, the column is filled only after the
initial insert by the set method.
2016-07-29 12:17:04 +02:00
Cédric Krier 7ca7f4c6f0 Allow to store Binary field in filestore
Two options are added on Binary field to define the column to use to store the
filestore id and the prefix to use.
Those options are used for Attachment and are configurable with conservative
default values.

issue5692
review25471003
2016-07-29 10:51:53 +02:00
Sergi Almacellas Abellana cca2b961b0 Allow records with different context on ModelStorage.save
issue5753
review22201002
2016-07-29 10:30:00 +02:00
Cédric Krier b2e5e20a06 Remove remaining files with sha field
issue3713
2016-07-11 18:34:43 +02:00
Sergi Almacellas Abellana b24c4143a2 Remove string attribute from ir.ui.view and ModelView.view_header_get
issue2350
review24251002
2016-07-05 12:42:46 +02:00
Cédric Krier 6232dabdf3 Don't check write access on model for button with groups
issue5010
review23181002
2016-06-30 21:51:03 +02:00
Cédric Krier 1265f7c42f Reset context when saving records
The method set_context does not replace the context but just update it.
So we could have leak of the surrounding into the save context.

issue5614
review28341002
2016-06-27 19:08:04 +02:00
Cédric Krier 8d8c489c83 Reset context when reading fields for browsing
The method set_context does not replace the context but just update it.
So we could have leak of the surrounding into the read context.

issue5614
review25161002
2016-06-14 16:00:15 +02:00
Nicolas Évrard 33224eeaa3 Check self.id against None before comparing to 0
issue5590
review25111002
2016-06-03 13:01:39 +02:00
Cédric Krier 66a6f7aad4 Keep colspan attribute when replacing field without access rights
The colspan attribute is important to keep the layout of the view intact.
So we must keep it after clearing all other attributes.

issue5444
review21901002
2016-04-02 15:22:24 +02:00
Cédric Krier 46ff36af7b Use str to test exception instead of unicode in integrity error
issue5446
review19161003
2016-04-01 10:29:51 +02:00
Cédric Krier 792d623c7b Improve threshold between rebuild and update MPTT
Indeed we should count the number of nodes updated instead of the number of
queries.

rebuild: 1 write and 1 select on each node
update: (1 write + 3 select + 2 write on average ½ all nodes + 1 write on child
of id) on each ids

So the threshold is:

2 * count < (4 + 2 * count / 2 + 1 * x) * len(ids)
2 * count < (4 + count + x) * len(ids)

which can be approximated to

2 * count < count * len(ids)
2 < len(ids)

issue5399
review20861002
2016-03-21 23:43:22 +01:00
Cédric Krier 33b240736c Re-introduce iteration over keys
It was removed in changeset 808e05f4898c but indeed we need a copy list of the
keys because the dictionary is modified during the iteration.
2016-03-19 15:25:49 +01:00
Cédric Krier 23c45fc511 Group records when calling set method for field with the same value
We need to loop to compare the values instead of using a dictionary because the
values are not necessary hashable. But it is still an improvement compared to
calling the set method for each record.

issue5398
review19111002
2016-03-19 12:07:27 +01:00
Cédric Krier 1380d60c45 Cache default values in ModelSQL.create
default values should be constant during the create transaction so we could
cache the result and avoid query it for each created record.

issue5397
review16121002
2016-03-19 12:04:35 +01:00
Cédric Krier 510931a8ab Use OrderedDict in Workflow.transition for cache alignment
This allows to loop over the key in the same order as the list of records.
Also avoid to use .keys() when iterating on dict because it generate a useless
list on Python2.
Use list on dict instead of .keys() to avoid one extra call on Python3 because
.key() return an iterator.

issue5396
review20061002
2016-03-19 11:59:52 +01:00
Cédric Krier 9dfb717088 Always use __name__ instead of _get_name to raise access_error
Other similar exception use __name__
2016-03-16 12:48:15 +01:00
Cédric Krier bfe9e5bea8 ModelStorage._clean_defaults must skip related fields
Related fields like '.rec_name' could be set as default value, they are not
defined in _fields and they must be cleaned.

issue5376
review17131002
2016-03-16 12:46:20 +01:00
Cédric Krier 9b94696b05 Speed up instantiation of Models
Pass as much possible, pre-computed parameters to __init__ to move their
computation outside the loop.

issue5294
review20721002
2016-03-15 19:01:47 +01:00
Cédric Krier 4d58b3a720 Don't remove from context the format of Binary fields
The getter of the Binary field could be called many times in the same
transaction, so popping out the format from the context create a side effect
that changes the requested format.

issue3774
review19981002
2016-03-05 17:26:27 +01:00
Cédric Krier 22dc3d23bc Remove __setattr__ from Model
This method is there to only skip the id attribute to be set using the field
__set__ but it has a cost as it is called each time an attribute is set.
So we store now the id value in the attribute '_id' which doesn't overload the
field and we adapt field __get__ for this new location.
The __getitem__ is also removed as it is deprecated since 2.6.

issue5296
review17031002
2016-03-04 00:19:18 +01:00
Cédric Krier 512808e151 Add LRUDictTransaction
issue5293
review22771002
2016-03-03 23:27:38 +01:00
Nicolas Évrard 2fef479575 Follow PEP-0249 for Transaction and backends
issue4949
review19781002
2016-03-03 21:51:57 +01:00
Nicolas Évrard 9aa648513e re-add the use of the case removed in changeset 0c62b08fa917
Removing the case resulted in the evaluation of expression that were not valid
like the cast of a string into an integer.

issue5335
review16011002
2016-02-19 12:43:12 +01:00
Cédric Krier af00126074 Allow to modify XML record with noupdate
issue5176
review19851002
2016-02-11 22:18:29 +01:00
Cédric Krier 29129855ec Add support for Python 3
issue3211
review7311002
2016-02-07 16:46:16 +01:00
Cédric Krier 81f1e8b6db Fix typo when reading getter fields with datetime_field
issue5269
review20671002
2016-02-02 19:03:11 +01:00
Nicolas Évrard d4e3b605ef Add 'where' operator to xxx2many
issue4507
review12951002
2016-01-21 10:48:32 +01:00
Sergi Almacellas Abellana 2a723f2e52 Only rebuild mptt tree if needed
The tree will be only rebuild if a record with the default value of left or right fields exists.

issue5118
review16921002
2016-01-11 15:33:08 +01:00
Cédric Krier 1bd76628c6 Set view_ids attribute only if it is not empty
issue5207
review15861002
2015-12-31 14:17:03 +01:00
Cédric Krier 71c0e0a3af Allow nested inherited views
Search and use the recursive type of the views

issue5206
review17691002
2015-12-31 14:15:51 +01:00
Cédric Krier 1f04a58562 Remove comments from view.arch
A side effect of this change is that now the method parse only once the arch of
each view instead of dumping and parsing the intermediary result of
inheritance.

issue5189
review18831002
2015-12-31 14:13:03 +01:00
Sergi Almacellas Abellana 80b3679dd3 Backed out changeset ac3c495d797f 2015-12-28 15:29:21 +01:00
Sergi Almacellas Abellana fc58438188 Only rebuild mptt tree one time per model in a database update
issue5118
review20501002
2015-12-28 14:13:03 +01:00
Cédric Krier 2e37bf7852 Don't return changed many2one if the id is None
If the id is None, it is a temporary record which should not be considered as a
value change.

issue5190
review20601002
2015-12-27 20:03:59 +01:00
Cédric Krier 1a7c6c3a06 Add missing id on label
Fields without read access are replaced by empty label but they still require
at least a name attribute or an id.

issue5187
review19701002
2015-12-27 20:01:03 +01:00
Cédric Krier 5999bb231d Check all fields when writing a sequence of records, values
issue5167
review22631002
2015-12-16 13:47:33 +01:00
Cédric Krier bcd557da3b Many2Many are not sortable
fields_get should set sortable to False for Many2Many.

issue5123
review15821002
2015-11-15 12:45:41 -03:00
Cédric Krier 9a58954703 Add view_ids on tree view
issue5052
review24511002
2015-11-10 12:55:06 +01:00