Files
tryton/move.py
T
Cédric Krier b5936e06db Save less often cost values when doing move
We can save the cost values only when a cost value was computed for a product
already moved.
Also FIFO requires to save extra moves which can be included in the save loop
so the Move._do method returns an extra list of moves to save.

issue10640
review369361002
2021-08-27 08:59:26 +02:00

155 lines
5.7 KiB
Python

# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
from decimal import Decimal
from sql import operators, Literal
from trytond.i18n import gettext
from trytond.model import Workflow, ModelView, fields, Check
from trytond.model.exceptions import AccessError
from trytond.pool import Pool, PoolMeta
from trytond.transaction import Transaction
from trytond.modules.product import round_price
class Move(metaclass=PoolMeta):
__name__ = 'stock.move'
fifo_quantity = fields.Float(
'FIFO Quantity',
help="Quantity used by FIFO.")
fifo_quantity_available = fields.Function(fields.Float(
"FIFO Quantity Available",
help="Quantity available for FIFO"),
'get_fifo_quantity_available')
@classmethod
def __setup__(cls):
super(Move, cls).__setup__()
cls._allow_modify_closed_period.add('fifo_quantity')
t = cls.__table__()
cls._sql_constraints += [
('check_fifo_quantity_out',
Check(t, t.quantity >= t.fifo_quantity),
'product_cost_fifo.msg_move_fifo_quantity_greater'),
]
@staticmethod
def default_fifo_quantity():
return 0.0
def get_fifo_quantity_available(self, name):
return self.quantity - (self.fifo_quantity or 0)
@classmethod
def domain_fifo_quantity_available(cls, domain, tables):
table, _ = tables[None]
name, operator, value = domain
field = cls.fifo_quantity_available._field
Operator = fields.SQL_OPERATORS[operator]
column = (
cls.quantity.sql_column(table)
- cls.fifo_quantity.sql_column(table))
expression = Operator(column, field._domain_value(operator, value))
if isinstance(expression, operators.In) and not expression.right:
expression = Literal(False)
elif isinstance(expression, operators.NotIn) and not expression.right:
expression = Literal(True)
expression = field._domain_add_null(
column, operator, value, expression)
return expression
def _update_fifo_out_product_cost_price(self):
'''
Update the product cost price of the given product on the move. Update
fifo_quantity on the concerned incomming moves. Return the
cost price for outputing the given product and quantity.
'''
pool = Pool()
Uom = pool.get('product.uom')
total_qty = Uom.compute_qty(self.uom, self.quantity,
self.product.default_uom, round=False)
with Transaction().set_context(company=self.company.id):
fifo_moves = self.product.get_fifo_move(total_qty)
cost_price = Decimal("0.0")
consumed_qty = 0.0
to_save = []
for move, move_qty in fifo_moves:
consumed_qty += move_qty
cost_price += move.get_cost_price() * Decimal(str(move_qty))
move_qty = Uom.compute_qty(self.product.default_uom, move_qty,
move.uom, round=False)
move.fifo_quantity = (move.fifo_quantity or 0.0) + move_qty
# Due to float, the fifo quantity result can exceed the quantity.
assert move.quantity >= move.fifo_quantity - move.uom.rounding
move.fifo_quantity = min(move.fifo_quantity, move.quantity)
to_save.append(move)
if consumed_qty:
cost_price = cost_price / Decimal(str(consumed_qty))
else:
cost_price = self.product.get_multivalue(
'cost_price', **self._cost_price_pattern)
# Compute average cost price
average_cost_price = self._compute_product_cost_price(
'out', product_cost_price=cost_price)
if cost_price:
cost_price = round_price(cost_price)
else:
cost_price = average_cost_price
return cost_price, average_cost_price, to_save
def _do(self):
cost_price, to_save = super(Move, self)._do()
if (self.from_location.type != 'storage'
and self.to_location.type == 'storage'
and self.product.cost_price_method == 'fifo'):
cost_price = self._compute_product_cost_price('in')
elif (self.to_location.type == 'supplier'
and self.from_location.type == 'storage'
and self.product.cost_price_method == 'fifo'):
cost_price = self._compute_product_cost_price('out')
elif (self.from_location.type == 'storage'
and self.to_location.type != 'storage'
and self.product.cost_price_method == 'fifo'):
fifo_cost_price, cost_price, moves = (
self._update_fifo_out_product_cost_price())
if self.cost_price_required and self.cost_price is None:
self.cost_price = fifo_cost_price
to_save.extend(moves)
return cost_price, to_save
@classmethod
@ModelView.button
@Workflow.transition('cancelled')
def cancel(cls, moves):
pass
@classmethod
def delete(cls, moves):
fifo_moves = cls.search([
('id', 'in', [m.id for m in moves]),
('fifo_quantity', '!=', 0.0),
])
if fifo_moves:
raise AccessError(
gettext('product_cost_fifo.msg_move_delete_fifo',
move=fifo_moves[0].rec_name))
super(Move, cls).delete(moves)
@classmethod
def copy(cls, moves, default=None):
if default is None:
default = {}
else:
default = default.copy()
default.setdefault('fifo_quantity', cls.default_fifo_quantity())
return super().copy(moves, default=default)