An empty string is not a valid required value

review411001
This commit is contained in:
Cédric Krier committed 2012-06-28 15:19:21 +02:00
1 parent b6f77e57f1
commit 2188fc3c6c
2 files changed
+6 -1

No files matched your search

+1 -1
View File
@@ -1062,7 +1062,7 @@ class ModelStorage(Model):
def required_test(value, field_name):
if (isinstance(value,
(BrowseRecordNull, type(None), type(False),
BrowseRecordList))
BrowseRecordList, basestring))
and not value):
self.raise_user_error('required_validation_record',
error_args=self._get_error_args(field_name))
+5
View File
@@ -1040,6 +1040,11 @@ class FieldsTestCase(unittest.TestCase):
self.failUnlessRaises(Exception, self.char_required.create, {})
transaction.cursor.rollback()
self.failUnlessRaises(Exception, self.char_required.create, {
'char': '',
})
transaction.cursor.rollback()
char5_id = self.char_required.create({
'char': 'Test',
})