tryton-do/tryton
2
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fill blank state of empty favorite menu

Browse Source 
Closes #14574
This commit is contained in:
Cédric Krier
2026-02-04 12:52:19 +01:00
parent 92e85ab498
commit 236ef98b7a
2 changed files with 48 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sao/src/sao.js
+39 -22
View File
@@ -687,30 +687,38 @@ var Sao = {
});
jQuery('#user-favorites').append(menu);
Sao.rpc(args, session).then(function(fav) {
fav.forEach(function(menu_item) {
var a = jQuery('<a/>', {
'href': '#'
});
var id = menu_item[0];
var li = jQuery('<li/>', {
'role': 'presentation'
});
var icon = Sao.common.ICONFACTORY.get_icon_img(
menu_item[2], {'class': 'favorite-icon'});
a.append(icon);
li.append(a);
a.append(menu_item[1]);
a.click(function(evt) {
evt.preventDefault();
Sao.favorites_menu_clear();
// ids is not defined to prevent to add suffix
Sao.Action.exec_keyword('tree_open', {
'model': Sao.main_menu_screen.model_name,
'id': id,
if (!fav.length) {
jQuery('<li/>', {
'class': 'dropdown-header',
'role': 'presentation',
}).text(Sao.i18n.gettext("Check menu entries to add favorites"))
.appendTo(menu);
} else {
fav.forEach(function(menu_item) {
var a = jQuery('<a/>', {
'href': '#'
});
var id = menu_item[0];
var li = jQuery('<li/>', {
'role': 'presentation'
});
var icon = Sao.common.ICONFACTORY.get_icon_img(
menu_item[2], {'class': 'favorite-icon'});
a.append(icon);
li.append(a);
a.append(menu_item[1]);
a.click(function(evt) {
evt.preventDefault();
Sao.favorites_menu_clear();
// ids is not defined to prevent to add suffix
Sao.Action.exec_keyword('tree_open', {
'model': Sao.main_menu_screen.model_name,
'id': id,
});
});
menu.append(li);
});
menu.append(li);
});
}
});
}
};
@@ -857,6 +865,11 @@ var Sao = {
var icon = 'tryton-star';
if (!record._values.favorite) {
icon += '-border';
cell.attr('title', Sao.i18n.gettext(
"Add to favorites"));
} else {
cell.attr('title', Sao.i18n.gettext(
"Remove from favorites"));
}
cell.data('star', Boolean(record._values.favorite));
Sao.common.ICONFACTORY.get_icon_url(icon)
@@ -886,9 +899,13 @@ var Sao = {
if (!star) {
icon = 'tryton-star';
method = 'set';
button.attr('title', Sao.i18n.gettext(
"Remove from favorites"));
} else {
icon = 'tryton-star-border';
method = 'unset';
button.attr('title', Sao.i18n.gettext(
"Add to favorites"));
}
button.data('star', !star);
Sao.common.ICONFACTORY.get_icon_url(icon)
tryton/tryton/gui/main.py
+9 -3
View File
@@ -477,10 +477,16 @@ class Main(Gtk.Application):
process_exception=False)
except RPCException:
return False
for id_, name, icon in favorites:
menuitem = Gtk.MenuItem(label=name)
menuitem.connect('activate', _action_favorite, id_)
if not favorites:
menuitem = Gtk.MenuItem(
label=_("Check menu entries to add favorites"))
menuitem.set_sensitive(False)
self.menu_favorite.add(menuitem)
else:
for id_, name, icon in favorites:
menuitem = Gtk.MenuItem(label=name)
menuitem.connect('activate', _action_favorite, id_)
self.menu_favorite.add(menuitem)
self.menu_favorite.show_all()
def favorite_unset(self):