tryton-do/tryton
2
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Correctly rename column with SQLite

Browse Source 
The table must be recreated if the target column does not exist.
Also temporary column name should use double underscore as module may use
single underscore.

issue7978
review52591002
This commit is contained in:
Cédric Krier
2019-01-15 11:30:20 +01:00
parent 07c296fc27
commit 342bc9f13d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
trytond/backend/sqlite/table.py
+3 -3
View File
@@ -93,7 +93,7 @@ class TableHandler(TableHandlerInterface):
transaction = Transaction()
database = transaction.database
cursor = transaction.connection.cursor()
temp_table = '_temp_%s' % self.table_name
temp_table = '__temp_%s' % self.table_name
TableHandler.table_rename(self.table_name, temp_table)
new_table = TableHandler(self._model, history=self.history)
columns, old_columns = [], []
@@ -116,7 +116,7 @@ class TableHandler(TableHandlerInterface):
def column_rename(self, old_name, new_name):
if self.column_exist(old_name):
if self.column_exist(new_name):
if not self.column_exist(new_name):
self._recreate_table({old_name: {'name': new_name}})
else:
logger.warning(
@@ -322,7 +322,7 @@ class TableHandler(TableHandlerInterface):
transaction = Transaction()
database = transaction.database
cursor = transaction.connection.cursor()
temp_table = '_temp_%s' % self.table_name
temp_table = '__temp_%s' % self.table_name
TableHandler.table_rename(self.table_name, temp_table)
new_table = TableHandler(self._model, history=self.history)
for name, values in self._columns.items():