Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
This commit is contained in:
Cédric Krier committed 2020-03-01 12:33:53 +01:00
1 parent 6aecfc6f28
commit 721e5b885d
7 files changed
+13 -16

No files matched your search

+2
View File
@@ -0,0 +1,2 @@
[flake8]
ignore=E123,E124,E126,E128,W503
+5 -5
View File
@@ -2,16 +2,16 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
from .party import *
from .sale import *
from . import party
from . import sale
from . import configuration
def register():
Pool.register(
Party,
PartySaleShipmentGroupingMethod,
Sale,
party.Party,
party.PartySaleShipmentGroupingMethod,
sale.Sale,
configuration.Configuration,
configuration.ConfigurationSaleMethod,
module='sale_shipment_grouping', type_='model')
-3
View File
@@ -3,9 +3,6 @@
from trytond.model import fields
from trytond.pool import Pool, PoolMeta
__all__ = ['Configuration', 'ConfigurationSaleMethod']
sale_shipment_grouping_method = fields.Selection(
'get_sale_shipment_grouping_methods', "Sale Shipment Grouping Method",
help="The default shipment grouping method for new customers.")
-2
View File
@@ -5,8 +5,6 @@ from trytond.model import ModelSQL, ValueMixin, fields
from trytond.pool import PoolMeta, Pool
from trytond.tools.multivalue import migrate_property
__all__ = ['Party', 'PartySaleShipmentGroupingMethod']
class Party(metaclass=PoolMeta):
__name__ = 'party.party'
-2
View File
@@ -4,8 +4,6 @@
from trytond.pool import PoolMeta
from trytond.transaction import Transaction
__all__ = ['Sale']
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
+5 -3
View File
@@ -79,8 +79,9 @@ setup(name=name,
keywords='tryton sale shipment grouping',
package_dir={'trytond.modules.sale_shipment_grouping': '.'},
packages=(
['trytond.modules.sale_shipment_grouping'] +
['trytond.modules.sale_shipment_grouping.%s' % p for p in find_packages()]
['trytond.modules.sale_shipment_grouping']
+ ['trytond.modules.sale_shipment_grouping.%s' % p
for p in find_packages()]
),
package_data={
'trytond.modules.sale_shipment_grouping': (info.get('xml', [])
@@ -93,7 +94,8 @@ setup(name=name,
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
'License :: OSI Approved :: '
'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
+1 -1
View File
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
from trytond.modules.sale_shipment_grouping.tests.test_sale_shipment_grouping import suite
from trytond.modules.sale_shipment_grouping.tests.test_sale_shipment_grouping import suite # noqa: E501
except ImportError:
from .test_sale_shipment_grouping import suite