Do not consider sale as done when invoice or shipment state are none

If there are still line to invoice or to ship, the sale should not be done.

Closes #12594

modules/sale/sale.py

@@ -960,11 +960,13 @@ class Sale(
 
     def is_done(self):
         return ((self.invoice_state == 'paid'
-                or self.invoice_state == 'none')
+                or (self.invoice_state == 'none'
+                    and all(not l.quantity
+                        for l in self.lines if l.type == 'line')))
             and (self.shipment_state == 'sent'
-                or self.shipment_state == 'none'
-                or all(l.product.type == 'service'
-                    for l in self.lines if l.product)))
+                or (self.shipment_state == 'none'
+                    and all(l.product.type == 'service'
+                        for l in self.lines if l.product))))
 
     @classmethod
     def delete(cls, sales):

modules/sale/tests/scenario_sale_manual_invoice.rst

@@ -68,7 +68,7 @@ Sale with manual invoice method::
     >>> sale.click('quote')
     >>> sale.click('confirm')
     >>> sale.state
-    'done'
+    'processing'
     >>> sale.invoice_state
     'none'
     >>> len(sale.invoices)

modules/sale/tests/scenario_sale_manual_shipment.rst

@@ -56,7 +56,7 @@ Sale with manual shipment method::
     >>> sale.click('quote')
     >>> sale.click('confirm')
     >>> sale.state
-    'done'
+    'processing'
     >>> len(sale.shipments)
     0