Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503

__init__.py

@@ -7,7 +7,7 @@ from . import party
 def register():
     Pool.register(
         party.RelationType,
-        party.PartyRelation,
-        party.PartyRelationAll,
+        party.Relation,
+        party.RelationAll,
         party.Party,
         module='party_relationship', type_='model')

party.py

@@ -6,8 +6,6 @@ from trytond.pool import Pool, PoolMeta
 from trytond.model import ModelSQL, ModelView, fields
 from trytond.transaction import Transaction
 
-__all__ = ['RelationType', 'PartyRelation', 'PartyRelationAll', 'Party']
-
 
 class RelationType(ModelSQL, ModelView):
     'Relation Type'
@@ -19,7 +17,7 @@ class RelationType(ModelSQL, ModelView):
         help="Create automatically the reverse relation.")
 
 
-class PartyRelation(ModelSQL):
+class Relation(ModelSQL):
     'Party Relation'
     __name__ = 'party.relation'
 
@@ -43,7 +41,7 @@ class PartyRelation(ModelSQL):
             ]
 
 
-class PartyRelationAll(PartyRelation, ModelView):
+class RelationAll(Relation, ModelView):
     'Party Relation'
     __name__ = 'party.relation.all'
 
@@ -62,8 +60,8 @@ class PartyRelationAll(PartyRelation, ModelView):
         reverse_tables = {
             None: (relation, None),
             'type': {
-                None: (type, (relation.type == type.id) &
-                    (type.reverse != Null)),
+                None: (type, (relation.type == type.id)
+                    & (type.reverse != Null)),
                 },
             }
 
@@ -192,7 +190,8 @@ class PartyRelationAll(PartyRelation, ModelView):
 
         # Clean cursor cache
         for cache in list(Transaction().cache.values()):
-            for cache in (cache, list(cache.get('_language_cache', {}).values())):
+            for cache in (cache,
+                    list(cache.get('_language_cache', {}).values())):
                 if cls.__name__ in cache:
                     for record in relations:
                         for record_id in (record.id, record.reverse_id):

setup.py

@@ -79,8 +79,9 @@ setup(name=name,
     keywords='tryton party relationship',
     package_dir={'trytond.modules.party_relationship': '.'},
     packages=(
-        ['trytond.modules.party_relationship'] +
-        ['trytond.modules.party_relationship.%s' % p for p in find_packages()]
+        ['trytond.modules.party_relationship']
+        + ['trytond.modules.party_relationship.%s' % p
+            for p in find_packages()]
         ),
     package_data={
         'trytond.modules.party_relationship': (info.get('xml', [])
@@ -93,7 +94,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',

tests/__init__.py

@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.party_relationship.tests.test_party_relationship import suite
+    from trytond.modules.party_relationship.tests.test_party_relationship import suite  # noqa: E501
 except ImportError:
     from .test_party_relationship import suite