tryton-do/tryton
2
0 Fork 0
Code Issues Pull Requests 2 Actions 2 Packages Projects Releases Wiki Activity

Remove id to on_change calls that are cached

Browse Source 
issue8234
review275131002
This commit is contained in:
Cédric Krier committed 2019-04-08 10:14:39 +02:00
1 parent a16942501e
commit 8e93249ac8
1 file changed
+29 -12
Download Patch File Download Diff File Expand all files Collapse all files
src/model.js
+29 -12
View File
@@ -960,7 +960,6 @@
});
result[arg] = scope;
});
result.id = this.id;
return result;
},
on_change: function(fieldnames) {
@@ -974,12 +973,21 @@
}
}.bind(this));
if (!jQuery.isEmptyObject(values)) {
var prm = this.model.execute('on_change',
[values, fieldnames], this.get_context());
return prm.then(function(changes) {
return jQuery.when.apply(jQuery,
changes.map(this.set_on_change.bind(this)));
}.bind(this));
var prm;
if (fieldnames.length == 1) {
prm = this.model.execute(
'on_change_' + fieldnames[0],
[values], this.get_context())
.then(this.set_on_change.bind(this));
} else {
prm = this.model.execute('on_change',
[values, fieldnames], this.get_context())
.then(function(changes) {
return jQuery.when.apply(jQuery,
changes.map(this.set_on_change.bind(this)));
}.bind(this));
}
return prm;
} else {
return jQuery.when();
}
@@ -1024,17 +1032,26 @@
}
var prms = [];
var prm;
if (!jQuery.isEmptyObject(fieldnames)) {
prm = this.model.execute('on_change_with',
[values, Object.keys(fieldnames)], this.get_context());
prms.push(prm.then(this.set_on_change.bind(this)));
}
var set_on_change = function(fieldname) {
return function(result) {
return this.model.fields[fieldname].set_on_change(
this, result);
};
};
fieldnames = Object.keys(fieldnames);
if (fieldnames) {
if (fieldnames.length == 1) {
prm = this.model.execute(
'on_change_with_' + fieldnames[0],
[values], this.get_context());
prms.push(prm.then(set_on_change(fieldnames[0]).bind(this)));
} else {
prm = this.model.execute(
'on_change_with',
[values, Object.keys(fieldnames)], this.get_context());
prms.push(prm.then(this.set_on_change.bind(this)));
}
}
for (fieldname in later) {
if (!later.hasOwnProperty(fieldname)) {
continue;