Round quantity computing in search clause

The internal quantity is stored without precision constraint and so the sum
result of many rows cumulate the rounding issue.
So the quantity must be rounded to return correct result when operator is
equality.
But as getting the digits from the product default uom would require to make
many joins, the simplest and more efficient solution is to use the highest
digits of the units.

issue11235
review390001002
This commit is contained in:
Cédric Krier
2022-02-17 00:37:39 +01:00
parent 6ef3e8c323
commit 9256ae7d62
+10 -2
View File
@@ -8,8 +8,9 @@ from decimal import Decimal
from itertools import groupby
from sql import Column, For, Literal, Null, Union
from sql.aggregate import Sum
from sql.aggregate import Max, Sum
from sql.conditionals import Case, Coalesce
from sql.functions import Round
from trytond.i18n import gettext
from trytond.model import Check, Model, ModelSQL, ModelView, Workflow, fields
@@ -118,6 +119,8 @@ class StockMixin(object):
pool = Pool()
Product = pool.get('product.product')
Move = pool.get('stock.move')
Uom = pool.get('product.uom')
uom = Uom.__table__()
if not location_ids or not domain:
return []
@@ -135,7 +138,12 @@ class StockMixin(object):
query = Move.compute_quantities_query(
location_ids, with_childs, grouping=grouping)
col_id = Column(query, grouping[position])
quantity = Sum(query.quantity)
# We need to round the result to have same result as
# products_by_location but as we do not have the unit, we use
# the biggest digits of all unit as best approximation.
quantity = Round(
fields.Numeric('quantity').sql_cast(Sum(query.quantity)),
uom.select(Max(uom.digits)))
group_by = [Column(query, key).as_(key) for key in grouping]
return [('id', 'in', query.select(
col_id,