tryton-do/tryton
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add support for reducing size of char if all rows are lower

Browse Source
This commit is contained in:
Cédric Krier
2026-06-26 00:09:48 +02:00
parent 07408dea49
commit aacc97f905
2 changed files with 30 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
trytond/trytond/backend/postgresql/table.py
+15 -6
View File
@@ -384,12 +384,21 @@ class TableHandler(TableHandlerInterface):
elif from_size and from_size < field_size:
self.alter_size(column_name, column_type[1])
else:
logger.warning(
'Unable to migrate column %s on table %s '
'from varchar(%s) to varchar(%s).',
column_name, self.table_name,
from_size if from_size and from_size > 0 else "",
field_size)
cursor.execute(SQL(
'SELECT id FROM {} '
'WHERE CHAR_LENGTH({}) > %s LIMIT 1').format(
Identifier(self.table_name),
Identifier(column_name)),
(field_size,))
if not cursor.rowcount:
self.alter_size(column_name, column_type[1])
else:
logger.warning(
'Unable to migrate column %s on table %s '
'from varchar(%s) to varchar(%s).',
column_name, self.table_name,
from_size if from_size and from_size > 0 else "",
field_size)
return
column_type = column_type[1]
trytond/trytond/backend/sqlite/table.py
+15 -6
View File
@@ -200,6 +200,7 @@ class TableHandler(TableHandlerInterface):
def _add_raw_column(
self, column_name, column_type, default=None, field_size=None):
cursor = Transaction().connection.cursor()
if self.column_exist(column_name):
base_type = column_type[0].upper()
if base_type != self._columns[column_name]['typname']:
@@ -231,12 +232,20 @@ class TableHandler(TableHandlerInterface):
elif from_size and from_size < field_size:
self.alter_size(column_name, column_type[1])
else:
logger.warning(
'Unable to migrate column %s on table %s '
'from varchar(%s) to varchar(%s).',
column_name, self.table_name,
from_size if from_size and from_size > 0 else "",
field_size)
cursor.execute(
'SELECT id FROM %s WHERE LENGTH(%s) > %%s LIMIT 1' % (
_escape_identifier(self.table_name),
_escape_identifier(column_name)),
(field_size,))
if not cursor.fetchone():
self.alter_size(column_name, column_type[1])
else:
logger.warning(
'Unable to migrate column %s on table %s '
'from varchar(%s) to varchar(%s).',
column_name, self.table_name,
from_size if from_size and from_size > 0 else "",
field_size)
return
cursor = Transaction().connection.cursor()