Raise NotImplementedError when setting Function field without setter

issue7985 review265101002
2019-03-27 00:28:57 +01:00
parent 53afc5ea03
commit b1247201ef
1 changed files with 9 additions and 2 deletions
@@ -885,8 +885,15 @@ class Model(object):
        'Return dictionary values'
        if fields is None:
            fields = self._values.keys()
-        return dict((x, getattr(self, '__%s_value' % x)) for x in fields
-                if x not in ('id', '_timestamp'))
+        values = {}
+        for name in fields:
+            if name in ['id', '_timestamp']:
+                continue
+            definition = self._fields[name]
+            if definition.get('readonly') and definition['type'] != 'one2many':
+                continue
+            values[name] = getattr(self, '__%s_value' % name)
+        return values

    @property
    def _timestamp(self):