Remove early attribute clearing in destroy
Removing those attributes could lead to errors where in the code we expect to have those attributes. It is better to leave them and let the garbage collector detect them. review3251002
This commit is contained in:
1 parent
a7ae4d4520
commit
efac3f6036
10 files changed
-30
No files matched your search
@@ -186,10 +186,6 @@ class Form(SignalEvent, TabContent):
|
||||
|
||||
def destroy(self):
|
||||
self.screen.destroy()
|
||||
self.screen = None
|
||||
self.widget = None
|
||||
#self.scrolledwindow.destroy()
|
||||
#self.scrolledwindow = None
|
||||
|
||||
def sel_ids_get(self):
|
||||
return self.screen.sel_ids_get()
|
||||
|
||||
@@ -416,7 +416,6 @@ class Group(SignalEvent, list):
|
||||
pass
|
||||
self.clear()
|
||||
super(Group, self).destroy()
|
||||
self.parent = None
|
||||
|
||||
def get_by_path(self, path):
|
||||
'return record by path'
|
||||
|
||||
@@ -622,8 +622,5 @@ class Record(SignalEvent):
|
||||
if hasattr(v, 'destroy'):
|
||||
v.destroy()
|
||||
super(Record, self).destroy()
|
||||
self.group = None
|
||||
self.value = None
|
||||
self.next = None
|
||||
self.destroyed = True
|
||||
pool.remove(self)
|
||||
@@ -324,11 +324,6 @@ class Screen(SignalEvent):
|
||||
for view in self.views:
|
||||
view.destroy()
|
||||
super(Screen, self).destroy()
|
||||
self.parent = None
|
||||
self.__group = None
|
||||
self.__current_record = None
|
||||
self.screen_container = None
|
||||
self.widget = None
|
||||
|
||||
def default_row_activate(self):
|
||||
if (self.current_view.view_type == 'tree' and
|
||||
|
||||
@@ -21,9 +21,6 @@ class Calendar_(goocalendar.Calendar):
|
||||
self.event_store = event_store
|
||||
self.current_domain_period = self.get_displayed_period()
|
||||
|
||||
def destroy(self):
|
||||
super(Calendar_, self).destroy()
|
||||
|
||||
def set_default_date(self, record, selected_date):
|
||||
attrs = common.node_attributes(self.root_node)
|
||||
dtstart = attrs.get('dtstart')
|
||||
|
||||
@@ -64,10 +64,6 @@ class ViewForm(ParserView):
|
||||
widget.destroy()
|
||||
del self.widgets[widget_name]
|
||||
self.widget.destroy()
|
||||
self.widget = None
|
||||
self.widgets = None
|
||||
self.screen = None
|
||||
self.state_widgets = None
|
||||
|
||||
def cancel(self):
|
||||
for widgets in self.widgets.itervalues():
|
||||
|
||||
@@ -130,8 +130,6 @@ class Many2Many(WidgetInterface):
|
||||
|
||||
def destroy(self):
|
||||
self.screen.destroy()
|
||||
self.widget.destroy()
|
||||
del self.widget
|
||||
|
||||
def color_set(self, name):
|
||||
super(Many2Many, self).color_set(name)
|
||||
|
||||
@@ -21,9 +21,6 @@ class ViewGraph(ParserView):
|
||||
for widget in self.widgets.keys():
|
||||
self.widgets[widget].destroy()
|
||||
del self.widgets[widget]
|
||||
self.widget = None
|
||||
self.screen = None
|
||||
self.state_widgets = None
|
||||
|
||||
def cancel(self):
|
||||
pass
|
||||
|
||||
@@ -727,9 +727,6 @@ class ViewList(ParserView):
|
||||
def destroy(self):
|
||||
self.save_width_height()
|
||||
self.widget_tree.destroy()
|
||||
self.screen = None
|
||||
self.widget_tree = None
|
||||
self.widget = None
|
||||
|
||||
def __sig_switch(self, treeview, path, column):
|
||||
if column._type == 'button':
|
||||
|
||||
@@ -119,8 +119,6 @@ class Wizard(object):
|
||||
def destroy(self):
|
||||
if self.screen:
|
||||
self.screen.destroy()
|
||||
del self.screen
|
||||
del self.widget
|
||||
|
||||
def end(self):
|
||||
try:
|
||||
|
||||
Reference in new issue
Block a user