Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503

__init__.py

@@ -1,13 +1,13 @@
 # This file is part of Tryton.  The COPYRIGHT file at the top level of
 # this repository contains the full copyright notices and license terms.
 from trytond.pool import Pool
-from .product import *
-from .move import *
+from . import product
+from . import move
 
 
 def register():
     Pool.register(
-        Template,
-        Product,
-        Move,
+        product.Template,
+        product.Product,
+        move.Move,
         module='product_cost_fifo', type_='model')

move.py

@@ -10,8 +10,6 @@ from trytond.model.exceptions import AccessError
 from trytond.pool import Pool, PoolMeta
 from trytond.transaction import Transaction
 
-__all__ = ['Move']
-
 
 class Move(metaclass=PoolMeta):
     __name__ = 'stock.move'

product.py

@@ -7,8 +7,6 @@ from trytond.config import config
 from trytond.transaction import Transaction
 from trytond.pool import Pool, PoolMeta
 
-__all__ = ['Template', 'Product']
-
 
 class Template(metaclass=PoolMeta):
     __name__ = 'product.template'

setup.py

@@ -79,8 +79,8 @@ setup(name=name,
     keywords='tryton product cost fifo',
     package_dir={'trytond.modules.product_cost_fifo': '.'},
     packages=(
-        ['trytond.modules.product_cost_fifo'] +
-        ['trytond.modules.product_cost_fifo.%s' % p for p in find_packages()]
+        ['trytond.modules.product_cost_fifo']
+        + ['trytond.modules.product_cost_fifo.%s' % p for p in find_packages()]
         ),
     package_data={
         'trytond.modules.product_cost_fifo': (info.get('xml', [])
@@ -95,7 +95,8 @@ setup(name=name,
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
         'Intended Audience :: Manufacturing',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',

tests/__init__.py

@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.product_cost_fifo.tests.test_product_cost_fifo import suite
+    from trytond.modules.product_cost_fifo.tests.test_product_cost_fifo import suite  # noqa: E501
 except ImportError:
     from .test_product_cost_fifo import suite