tryton-do/tryton
2
0 Fork 0
Code Issues Pull Requests 2 Actions 2 Packages Projects Releases Wiki Activity

Reduce number of call to display in set_default

Browse Source 
issue7578
review66311002
This commit is contained in:
Cédric Krier committed 2018-07-27 17:36:09 +02:00
1 parent 53ead8b484
commit fdf6ccc46c
1 file changed
+18 -9
Download Patch File Download Diff File Expand all files Collapse all files
src/model.js
+18 -9
View File
@@ -357,9 +357,12 @@
this.model.execute('default_get', [added, this.context()])
.then(function(values) {
new_.forEach(function(record) {
record.set_default(values);
record.set_default(values, true, false);
});
});
this.root_group().screens.forEach(function(screen) {
return screen.display();
});
}.bind(this));
}
};
array.destroy = function() {
@@ -862,10 +865,13 @@
}
return jQuery.when();
},
set_default: function(values, validate) {
set_default: function(values, validate, display) {
if (validate === undefined) {
validate = true;
}
if (display === undefined) {
display = true;
}
var promises = [];
var fieldnames = [];
for (var fname in values) {
@@ -893,10 +899,12 @@
return this.on_change(fieldnames).then(function() {
return this.on_change_with(fieldnames).then(function() {
var callback = function() {
return this.group.root_group().screens
.forEach(function(screen) {
return screen.display();
});
if (display) {
return this.group.root_group().screens
.forEach(function(screen) {
return screen.display();
});
}
}.bind(this);
if (validate) {
return this.validate(null, true)
@@ -1969,8 +1977,9 @@
var new_record = group.new_(false);
if (default_) {
// Don't validate as parent will validate
promises.push(new_record.set_default(vals, false));
group.add(new_record);
promises.push(new_record.set_default(
vals, false, false));
group.add(new_record, -1, false);
} else {
promises.push(new_record.set(vals));
group.push(new_record);