It is too complex and expensive to lazy create the connection pool because all
methods which uses the pool needs to acquire a lock. So it is easier to create
it when the instance is also created. In this case, on closing the database, it
should be unregistered from the instances dictionary.
issue6202
review32991002
If no protocol convert the data into a Response and if the data is an exception
it should be returned as an Internal Server Error instead of a succeed
response.
The exception can be used as description for the Internal Server Error.
issue6201
review31951002
The test was using the field name instead of the field instance.
It is better to keep the usual convention of using fname for name and field for
the instance.
issue6208
review33011002
Such translations should not be linked to the original report module as they
are only available in this database.
The translations menu entry should show also those who are not linked to a
module.
issue6059
review29761002
Since changeset de90bf5435ce instance records are used (instead of writing the
values) but when they are read with the check_access, as this context is used
to save the values, they raise incorrect access error.
issue6115
review34541002
We create the foreign table if needed before adding the foreign key constraint,
thus it is no more needed to order the registration of the ModelSQL.
issue5682
review32841002
With changeset b8d76b07910f, negative ids are no more instantiated but so
testing the model with __name__ does not work any more for such value.
Instead we must always compare using the string version of the model.
issue6091
review31801002
The reference fields can have a negative id if no record was selected on the
client. It is not expected to get such temporary instance from a reference
field on a saved record.
issue6091
review26941002
configfile can be a list with None values as the default argument value is a
list with TRYTOND_CONFIG environment variable which could be not set.
issue6101
review25891002
The method is often called under a new transaction so the created/deleted
records properties are cleared which makes it raises the wrong message if the
foreign key was created during the same transaction.
issue6038
review29781002
id is an Integer field which does not cast to int the values in the opposite of
Many2One which could receive an record instance.
issue6068
review31751003
Changeset9bb9fe4cd312 modified the behaviour to mark them as not activated but
they should be marked as to remove so their data is correctly removed with the
install/upgrade wizard.
issue6019
review31691002
The Selection field could have a method name as selection so
TranslatedSelection must call this method to get the selection values.
issue5999
review27791002
The button_change is similar to the on_change, they run under a read-only
transaction so there is no need to check the access right like it is done for
the button.
issue5983
review26841002
Cédric Krier