Use line's movable property to require incoterm

Closes #14332
2025-10-30 00:59:07 +01:00
parent e97cd24ec2
commit 0d5caa58e7
2 changed files with 2 additions and 2 deletions
@@ -32,7 +32,7 @@ class Purchase(IncotermAvailableMixin, metaclass=PoolMeta):
        super().check_for_quotation()
        if not self.incoterm and self._incoterm_required:
            for line in self.lines:
-                if line.product and line.product.type in {'goods', 'assets'}:
+                if line.movable:
                    raise PurchaseQuotationError(
                        gettext('incoterm'
                            '.msg_purchase_incoterm_required_for_quotation',
@@ -65,7 +65,7 @@ class Sale(IncotermAvailableMixin, metaclass=PoolMeta):
        super().check_for_quotation()
        if not self.incoterm and self._incoterm_required:
            for line in self.lines:
-                if line.product and line.product.type in {'goods', 'assets'}:
+                if line.movable:
                    raise SaleQuotationError(
                        gettext('incoterm'
                            '.msg_sale_incoterm_required_for_quotation',