Reuse planned shipping date when all moves are cancelled

issue11258 review366751002
2022-02-18 09:34:30 +01:00
parent 3c3cdfe520
commit 16b240c077
1 changed files with 3 additions and 3 deletions
@@ -1437,10 +1437,10 @@ class SaleLine(TaxableMixin, sequence_ordered(), ModelSQL, ModelView):

    @fields.depends('moves', methods=['planned_shipping_date'])
    def on_change_with_shipping_date(self, name=None):
-        if self.moves:
+        moves = [m for m in self.moves if m.state != 'cancelled']
+        if moves:
            dates = filter(
-                None, (m.effective_date or m.planned_date for m in self.moves
-                    if m.state != 'cancelled'))
+                None, (m.effective_date or m.planned_date for m in moves))
            return min(dates, default=None)
        return self.planned_shipping_date