Fix antipatern of create/write in loop

issue3516 review14951002
2016-12-19 09:56:13 +01:00
parent e8e3285f25
commit 1f545e9ced
1 changed files with 7 additions and 4 deletions
@@ -244,12 +244,15 @@ class ShipmentDrop(Workflow, ModelSQL, ModelView):
        Set planned date of moves for the shipments
        '''
        Move = Pool().get('stock.move')
+        to_write = []
        for shipment in shipments:
            planned_date = shipment._get_move_planned_date()
-            Move.write([m for m in shipment.moves
-                    if m.state not in ('assigned', 'done', 'cancel')], {
-                    'planned_date': planned_date,
-                    })
+            to_write.extend(([m for m in shipment.moves
+                        if m.state not in ('assigned', 'done', 'cancel')], {
+                        'planned_date': planned_date,
+                        }))
+        if to_write:
+            Move.write(*to_write)

    def get_moves(self, name):
        if name == 'supplier_moves':